Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Only Videoplayer gets re-rendered when video quality is changed and the whole page doesn't get reloaded. #220

Merged
merged 1 commit into from
Mar 17, 2024
Merged

Only Videoplayer gets re-rendered when video quality is changed and the whole page doesn't get reloaded. #220

merged 1 commit into from
Mar 17, 2024

Conversation

dhruvilmehta
Copy link
Contributor

@dhruvilmehta dhruvilmehta commented Mar 14, 2024 •
edited
Loading

Recording.2024-03-14.010249.1.mp4

Addresses issue #142
Features:

  1. the page doesn't reload whenever the video quality changes. Only the video URL gets changed. I added different videos to showcase that whenever quality changes, the video URL changes.
  2. the video progress continues whenever quality changes, instead of starting from zero.

Note: I didn't change anything in the Cache.ts file; it is changed just because of a prettier check while committing.

@hkirat hkirat merged commit 86274f2 into code100x:main Mar 17, 2024
1 check passed
@hkirat
Copy link
Contributor

hkirat commented Mar 17, 2024

/bounty $50

@nimit9 nimit9 mentioned this pull request Mar 21, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dhruvilmehta @hkirat